David @ Tokyo

This time I spotted a bug with the E17 window shading function, and the fix got added o(^_^)o
For you Windows users, "shading" is when you double-click in a window's title bar and roll up the window into the title bar like rolling up a window shade. You double-click and the window displays again. Basically similar to iconifying a window. There was a small bug where if you double-click but then double-click again before the window has finished shading, it goes a little wierd.

Here's my patch... (again very trivial but a little bit better than last time!)

UPDATE: My message to the list

david@Debian:~$ cat shadefix.diff
Index: e17/apps/e/src/bin/e_border.c
===================================================================
RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_border.c,v
retrieving revision 1.400
diff -u -r1.400 e_border.c
--- e17/apps/e/src/bin/e_border.c 21 Sep 2005 04:53:12 -0000 1.400
+++ e17/apps/e/src/bin/e_border.c 21 Sep 2005 14:12:29 -0000
@@ -1246,7 +1246,7 @@

E_OBJECT_CHECK(bd);
E_OBJECT_TYPE_CHECK(bd, E_BORDER_TYPE);
- if ((bd->fullscreen) || (bd->maximized)) return;
+ if ((bd->fullscreen) || (bd->maximized) || (bd->shading)) return;
if (!strcmp("borderless", bd->client.border.name)) return;
if (!bd->shaded)
{
@@ -1332,7 +1332,7 @@

E_OBJECT_CHECK(bd);
E_OBJECT_TYPE_CHECK(bd, E_BORDER_TYPE);
- if ((bd->fullscreen) || (bd->maximized)) return;
+ if ((bd->fullscreen) || (bd->maximized) || (bd->shading)) return;
if (bd->shaded)
{
// printf("UNSHADE!\n");
david@Debian:~$


And here it goes into CVS:


Enlightenment CVS committal

Author : sebastid
Project : e17
Module : apps/e

Dir : e17/apps/e/src/bin


Modified Files:
e_border.c


Log Message:
Don't allow to shade/unshade while shading.

===================================================================
RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_border.c,v
retrieving revision 1.400
retrieving revision 1.401
diff -u -3 -r1.400 -r1.401
--- e_border.c 21 Sep 2005 04:53:12 -0000 1.400
+++ e_border.c 21 Sep 2005 15:54:02 -0000 1.401
@@ -1246,7 +1246,7 @@

E_OBJECT_CHECK(bd);
E_OBJECT_TYPE_CHECK(bd, E_BORDER_TYPE);
- if ((bd->fullscreen) || (bd->maximized)) return;
+ if ((bd->fullscreen) || (bd->maximized) || (bd->shading)) return;
if (!strcmp("borderless", bd->client.border.name)) return;
if (!bd->shaded)
{
@@ -1332,7 +1332,7 @@

E_OBJECT_CHECK(bd);
E_OBJECT_TYPE_CHECK(bd, E_BORDER_TYPE);
- if ((bd->fullscreen) || (bd->maximized)) return;
+ if ((bd->fullscreen) || (bd->maximized) || (bd->shading)) return;
if (bd->shaded)
{
// printf("UNSHADE!\n");
- Show quoted text -

Labels: enlightenment